search

brefphp / bref

Serverless PHP on AWS Lambda
https://bref.sh
MIT License
3.09k stars 367 forks source link

Mistake in custom domains documentation #1687

Closed Adesin-fr closed 5 months ago

Adesin-fr commented 10 months ago

In the page main/src/pages/docs/use-cases/http/custom-domains.mdx

There might be a mistake : If I create the certificate on us-east-1, I can't find it when I create the API Gateway on my app region. To find the certificate, I must either create the API gateway to us-east-1, or create the certificate on the app regipon.

mnapoli commented 10 months ago

For REST APIs (API Gateway v1), you must create it in us-east-1.

For HTTP APIs (API Gateway v2), you must create it in your region.

Bref switched to v2 recently, that's maybe why the docs still mention us-east-1. Happy to merge a PR that updates this.

mnapoli commented 5 months ago

Closing because of inactivity.