search

brefphp / laravel-bridge

Package to use Laravel on AWS Lambda with Bref
https://bref.sh/docs/frameworks/laravel.html
MIT License
314 stars 63 forks source link

Fixed install conflict where package require older guzzlehttp/psr7 #50

Closed PixellUp closed 2 years ago

PixellUp commented 2 years ago

This PR bump minimum aws sdk php version to 3.187 to resolve an issue where current version 3.134 require guzzlehttp/psr7 ^1.4.1 but latest was sdk version 3.187 require guzzlehttp/psr7 ^1.7.0

image
mnapoli commented 2 years ago

Thanks! I'm not sure I understand the PR, is this related to this: https://github.com/aws/aws-sdk-php/issues/2264 ?

We've had this documentation change here: https://github.com/brefphp/bref/pull/979 to try to mitigate the impact. How will updating the minimum required version of the AWS SDK help here?

mnapoli commented 2 years ago

Oh by the way I just pushed the same changes in this repository to be consistent: https://github.com/brefphp/laravel-bridge/commit/5d28b0d6621d1de04c7df7e43e40687bd0ed5eba

PixellUp commented 2 years ago

Thanks for the quick response @mnapoli . Indeed for sure, this issue is related to https://github.com/aws/aws-sdk-php/issues/2264, however, I have to admit I was quick and rush to submit PR while the issue is not related to this package. Apologies for that.

That been said, I will close this PR as is not related to bref and will monitor aws sdk issue if there are any changes needed for future updated, instead of having to use --update-with-dependencies workaround.