search

brefphp / laravel-bridge

Package to use Laravel on AWS Lambda with Bref
https://bref.sh/docs/frameworks/laravel.html
MIT License
314 stars 63 forks source link

Allow Laravel v9 and Symfony v6 #64

Closed hmazter closed 2 years ago

hmazter commented 2 years ago

Update the package to allow it to be included in a Laravel v9 application that uses Symfony component v6.

Also, updated the CI tests to run on PHP 8.1 And bump shivammathur/setup-php to 2.16.0, since version 2.1.0 did not want to install PHP 7.3

hmazter commented 2 years ago

Not sure if it's possible to have a Test App that is installable on both PHP 7.3 and PHP 8.1 with appropriate dependencies.

mnapoli commented 2 years ago

Would it help if we dropped support for Laravel 6?

hmazter commented 2 years ago

I have updated the test app to a version (Laravel 8) that should be installable on everything from PHP 7.3 to PHP 8.1. But it is actually one version of Laravel that is tested, I don't know if that is an issue?

kris914g commented 2 years ago

What needs to be done to merge this PR? Would like to have Laravel 9 support 😄

hmazter commented 2 years ago

The thing that fails now in CI is PHPCS can not run because of this:

Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.0.2". You are running 7.4.12.

I'm not sure if I upgrade some dependencies that do not need an upgrade, or if phpcs needs to be updated.

kris914g commented 2 years ago

Can we get this merged soon?

kris914g commented 2 years ago

Can we get this merged soon?

@mnapoli is there something we are waiting for before we can merge?

omarkdev commented 2 years ago

@mnapoli It's possible to merge this one soon?

mnapoli commented 2 years ago

@omarkdev please calm down, this is becoming rude.

mnapoli commented 2 years ago

Thanks @hmazter!