brefphp / symfony-messenger

Bridge to use Symfony Messenger on AWS Lambda with Bref
MIT License
72 stars 22 forks source link

Feature: Add fifo middleware #64

Closed hadeli closed 2 years ago

hadeli commented 2 years ago

In order to facilite fifo attributes usage, i need to automate MessageGroupId & MessageDeduplicationId stamp adding

mnapoli commented 2 years ago

That sounds like a lot of new things to add, document and maintain. Could you clarify why we may want this? "In order to facilite fifo attributes usage" is not that clear to me.

shouze commented 2 years ago

@mnapoli Looks like it makes using SQS message groups plug & play. At the moment Symfony/Messenger just provides the Stamp but no Middleware and probably won't.

As you know, message groups provides the ability of highly concurrent processing messages like when you don't have FIFO queues, but with FIFO queues hence you don't have to bother with message order, the good part of FIFO with the good part of non FIFO.

mnapoli commented 2 years ago

Thanks!

Sorry I'll do a bit of meta, but my intrinsic motivation (to be transparent) is that I don't want to maintain anything more than necessary :p

The goal of this package is to make Symfony Messenger work out of the box on AWS Lambda. I'm wondering if new middlewares/stamps belong specifically in this package, or would instead better be in:

?

I understand the convenience of having this here (works out of the box), but is that feature strictly related to Bref? Or could these classes be useful outside of Bref/AWS lambda?

tyx commented 2 years ago

Hello @mnapoli ,

You're right this stuff is only a help to use AmazonSqsFifoStamp that belongs to Symfony sqs transport.

We will give a try to move this PR overthere

tyx commented 2 years ago

Just create PR on symfony repository : https://github.com/symfony/symfony/pull/48095

We can close here

mnapoli commented 2 years ago

Awesome!