search

bregman-arie / devops-resources

DevOps resources - Linux, Jenkins, AWS, SRE, Prometheus, Docker, Python, Ansible, Git, Kubernetes, Terraform, OpenStack, SQL, NoSQL, Azure, GCP
8.51k stars 2.14k forks source link

Adding CI/CD best practice #35

Closed amirfried closed 2 years ago

bregman-arie commented 2 years ago

By short you mean definition length or the time it takes to run?

amirfried commented 2 years ago

By short you mean definition length or the time it takes to run?

Yes. When a developer commit/merge, pipeline should provide fast feedback. Developer should not wait for hours/days to find out that something is wrong. For example, tests should run as fast as possible. This can be done by "shifting left" tests or/and with tools like https://www.sealights.io/product/test-impact-analysis/.

bregman-arie commented 2 years ago

By short you mean definition length or the time it takes to run?

Yes. When a developer commit/merge, pipeline should provide fast feedback. Developer should not wait for hours/days to find out that something is wrong. For example, tests should run as fast as possible. This can be done by "shifting left" tests or/and with tools like https://www.sealights.io/product/test-impact-analysis/.

I agree. In this case maybe you repharse it little bit. Either saying fast feedback or short execution time. Because right now it it's little bit obscure.

amirfried commented 2 years ago

Thanks for the comment. I have rephrased.

bregman-arie commented 2 years ago

Thanks for making the changes. Merging.