bregySilvan / TabSolution

2 stars 2 forks source link

WIP: #16 authentication in api #18

Open bregySilvan opened 6 years ago

bregySilvan commented 6 years ago

Description

Start application

Let's use ts-node instead of tsc command. It compiles and executes .ts files directly.

Note

In general we should avoid hardcoding stuff directly in classes. Pls put all variable data into config.ts file. Locations should also be added there.

Christian-Seematter commented 6 years ago

Nice working example of client-server communication. Decent info in the PR as well.

Will superagent be used within the angular app as well?

bregySilvan commented 6 years ago

I seperated server and client to different apps because it doesn't make sense to open up a new issue for that. In addition to that ts-node command got added for executing the application.

bregySilvan commented 6 years ago

@Christian-Seematter
I looked up some tools for making requests and superagent seemed to be the smartest and most flexible one to use.

olinator98 commented 6 years ago

@bregySilvan The client is now ready for the integration of the authentication. Cherio

bregySilvan commented 6 years ago

@olinator98 Go ahead and create the PR for your client which is finished. We can merge your changes on the client first and afterward I can commit my login integration directly into #18.