search

bregySilvan / TabSolution

2 stars 2 forks source link

Interface redeclaration #35

Closed olinator98 closed 6 years ago

olinator98 commented 6 years ago

In case of the main goal of our project has the description:

interface IBoard { title: string; description; imageURL; }

@noulyn @bregySilvan @TobiasMaru @TheScorpio13 You can see the implementation of the new interface, including the new version of the server, in my branch client.

bregySilvan commented 6 years ago

@olinator98 @TheScorpio13 I merged #27. Including the new server version from @olinator98.

olinator98 commented 6 years ago

@bregySilvan I think you merged the old version of the server in the master branch. I've created my PR including the Client and the server. Please review it.

Christian-Seematter commented 6 years ago

Shouldn't the update of the interface definition happen in https://github.com/bregySilvan/TabSolution/issues/28? Or was that done already? Is this issue actually to update the server accordingly?

@olinator98 Link to the PR you want to have reviewed so there won't be a mistake.

olinator98 commented 6 years ago

@Christian-Seematter Yes, I will update #28 directly. In this case, this issue can be closed.