breiko83 / zwo-editor

Zwift Workout Editor
https://www.zwiftworkout.com/
MIT License
59 stars 15 forks source link

Unable to save workout #48

Open dwaynefishel opened 3 years ago

dwaynefishel commented 3 years ago

Appears to be something about a workout I created that won't allow it to save. What I created was this: begin free ride: 10 min then 3 intervals of: Z4, 6:00 min, 180w Z5, 6:00 min, 220w free ride 7 min, free ride 5 min end

For some reason, this will not save, I tried from 2 machines

breiko83 commented 3 years ago

Hello!

I can have a look! Can you download the zwo file and send it to me here?

Alternatively can you send me the Link to your workout?

Thank you, Carlo

On Fri, 26 Feb 2021 at 18:30, dwaynefsihel notifications@github.com wrote:

Appears to be something about a workout I created that won't allow it to save. What I created was this: begin free ride: 10 min then 3 intervals of: Z4, 6:00 min, 180w Z5, 6:00 min, 220w free ride 7 min, free ride 5 min end

For some reason, this will not save, I tried from 2 machines

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/breiko83/zwo-editor/issues/48, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAESBV2COJHQXG4BDFPT7STTA7SF3ANCNFSM4YI47KGA .

dwaynefishel commented 3 years ago

I don't believe I can send, as when I attempt to download it, it goes to save first and that is what's not working...I was, however, able to go directly into zwift and use their editor and recreate the same thing, so appears that combination is OK? I just put a screenshot of what it looked like, and the data for the interval blocks were in the issue

On Fri, Feb 26, 2021 at 1:50 PM Carlo Schiesaro notifications@github.com wrote:

Hello!

I can have a look! Can you download the zwo file and send it to me here?

Alternatively can you send me the Link to your workout?

Thank you, Carlo

On Fri, 26 Feb 2021 at 18:30, dwaynefsihel notifications@github.com wrote:

Appears to be something about a workout I created that won't allow it to save. What I created was this: begin free ride: 10 min then 3 intervals of: Z4, 6:00 min, 180w Z5, 6:00 min, 220w free ride 7 min, free ride 5 min end

For some reason, this will not save, I tried from 2 machines

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/breiko83/zwo-editor/issues/48, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAESBV2COJHQXG4BDFPT7STTA7SF3ANCNFSM4YI47KGA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/breiko83/zwo-editor/issues/48#issuecomment-786829653, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATAGQ7PWK3PT4JMA6ZPEFLDTA7UQ5ANCNFSM4YI47KGA .

-- Dwayne E. Fishel 216.308.0270 dwaynefishel@gmail.com

breiko83 commented 3 years ago

I'm confused. It's not necessary to save before downloading. Yes, please if you can send a screenshot of the entire page and tell what browser you are using it will help.

Thanks!

dwaynefishel commented 3 years ago

Same here! I lost the tab in my browser but can recreate. When I clicked download after creating, it posted a saving.. dialog box and stuck there. I will attempt to recreate, clear browser cache, etc and see what happens...

On Fri, Feb 26, 2021 at 4:00 PM Carlo Schiesaro notifications@github.com wrote:

I'm confused. It's not necessary to save before downloading. Yes, please if you can send a screenshot of the entire page and tell what browser you are using it will help.

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/breiko83/zwo-editor/issues/48#issuecomment-786891447, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATAGQ7IJN7VEBJAYAH6BHYTTBADXZANCNFSM4YI47KGA .

-- Dwayne E. Fishel 216.308.0270 dwaynefishel@gmail.com

andpeab commented 3 years ago

i have the same issue. after finishing workout when i try to download, i get a "saving" box that just hangs forever. i also tried saving. filled out the workout details and the saving box hangs forever, even though the details are added to my workout. i can't download and the workout does not appear in my workout folder.

andpeab commented 3 years ago

Screenshot_2021-03-15 Threshold Ramps _USAT_PEABODY - Zwift Workout Editor

Tall-KU-RideOn commented 3 years ago

@breiko83 - I don't know if this is what the individuals above are seeing, but it is 'related' to saving a workout and having the 'Saving...' box never disappear

Uncaught Error: Reference.update failed: First argument contains Infinity in property 'workouts.z8wivfw3xvr.workout.0.length' at e (fb047f5……df353a8d017587.js:1) at fb047f5……df353a8d017587.js:1 at R (fb047f5……df353a8d017587.js:1) at e (fb047f5……df353a8d017587.js:1) at fb047f5……df353a8d017587.js:1 at R (fb047f5……df353a8d017587.js:1) at e (fb047f5……df353a8d017587.js:1) at fb047f5……df353a8d017587.js:1 at R (fb047f5……df353a8d017587.js:1) at e (fb047f5……df353a8d017587.js:1)

This error is strictly being seen when the Paces are not set properly within the UI. I was able to reproduce this by going to

  1. Go to the website - NOT being logged in
  2. Creating a new workout WITHOUT any Pace values set
  3. Saving the workout (at this time login box appears)
  4. Login
  5. Set pace values
  6. Click 'Save', the error is seen in the console
NicolajT commented 3 years ago

Hi I have experienced the same for some time. But it seems to be linked to use of "Text events": if I make a work out without any "Text events" it does save fine. But if I include one "text event", the "save" message wont disappear (like being told by the others). If I then delete the "Text events" again, then it saves just fine. That is why I think the error has to do with the "Text event".

Thanx for a great tool! I love it and have made several work outs :)

andpeab commented 3 years ago

the solution, it seems, is to refresh the page after finishing the workout. then it saves or downloads with no problem. the first time i tried this i was afraid it would refresh back to the blank workout page but it did not and i downloaded the workout file easily, including all of the text comments.

p0leary commented 2 years ago

+1 to both the bug and the workaround. Was getting a hanging save modal and was unable to download, but refreshing the browser resolved.

kylane commented 2 years ago

Same here!

Screenshot 2022-09-23 094544

Im noticing it happens usually when EDITING a text event - when you drop a new one and add text it saves - but editing one thats already been created causes the error.

pelleoss commented 2 years ago

as already said above, the work around is to reload the page. you won't lose your work and then it will be able to save. I have just tried and it worked.