search

brelkh / pe

0 stars 0 forks source link

Wrong error displayed for index out of bounds (delete index 0) #10

Open brelkh opened 2 years ago

brelkh commented 2 years ago

image.png

Error should be the following, rather than "incorrect command format":

image.png

soc-pe-bot commented 2 years ago

Team's Response

This is a cosmetic issue. We did address it in the QNA section:

image.png.

This is because by design, we check whether the parsed number is a positive integer first, before we check the size. In our error message shown, we still state that our index must be a positive integer for both the commands.

Perhaps we can improve on the English of the phrase "invalid command format"

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: Firstly, the group agrees that this is a bug by not rejecting this bug.

However, the group says that this is a cosmetic issue. According to PE instructions:

image.png

I disagree with the group's opinion of this being purely cosmetic, since this issue is not a "typo/spacing/layout/color/font issue". As the group highlights, "improving on the English" suggests it is not merely a typo, but a failure to communicate their idea with the reader appropriately. Furthermore, this issue does affect usage as the user will be confused about what is causing their input to be rejected due to the inconsistency.

As such, the severity cannot be veryLow, which is reserved for purely cosmetic flaws.