search

brelkh / pe

0 stars 0 forks source link

Person identifier does not differentiate if I accidentally add a space #2

Open brelkh opened 2 years ago

brelkh commented 2 years ago

image.png

If I accidentally input extra spaces in the name, I am not informed that I have entered a duplicate person.

nus-pe-script commented 2 years ago

Team's Response

We allow users the flexibility to add more spaces to differentiate names. This is a command-line application, so every space matters. Therefore this gives users the flexibility to make a user with name: Janald Ho, to differentiate a user with Janald Ho, for his own use.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: To begin with, the team does not allow duplicate names to be used, which acts as their "duplicate prevention". (eg. A user cannot have 2 students named Janald Ho.)

From the team's explanation, they allow this issue (not detecting extra spaces) since users may want to use extra spaces to differentiate between people.

However, if a user were to input Janald Ho Li Ming and Janald  Ho Li Ming (extra space before "Ho"), I think they would have more likely done this accidentally rather than intentionally. Since the team prevents duplicate names, as a user, I would think I am not able to input duplicate names in the first place. Thus, I may not be aware I have 2 Janald's (one with an extra space) in my address book referring to the same person.

As suggested in the PE instructions, a user may believe that duplicates are being prevented, but an extra space would go undetected.

image.png

Thus, I am not convinced by their explanation, and find that this feature (parsing user input for names) should have been designed differently (at least give a warning to the user). It is a low severity feature flaw.