search

brelkh / pe

0 stars 0 forks source link

Storage UML diagram error #20

Open brelkh opened 2 years ago

brelkh commented 2 years ago

image.png

Storage interface has an unlabelled arrow pointing towards it.

nus-pe-script commented 2 years ago

Team's Response

The arrow is trying to indicate that it is coming from somewhere else, outside of the storage class.

image.png

There is an imaginary class called HiddenOutside representing details outside of storage, the PlantUML limitation does not let us handle this.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The team states that the issue arises from a PlantUML limitation. However, the team could have chosen to work around this limitation. For example, they could have omitted this arrow as done in AB3 to make the diagram less confusing.

Furthermore, looking at the diagram again, if the team intended to communicate to readers that this arrow is "representing details outside of storage", the arrow should have extended outside of the storage class (see diagram below), and not start and end within the storage class.

image.png

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]