search

bremme / arduino-tm1637

Arduino library for using a 4 digit seven segment display with TM1636 or TM1637 driver IC
GNU General Public License v2.0
164 stars 62 forks source link

Changed TM1637_DEFAULT_BLINK_DELAY from 50 to 500 #26

Closed simoneluconi closed 4 years ago

simoneluconi commented 6 years ago

Normally in clocks the dots stay on for 500ms and off for 500ms, not 50ms.

bremme commented 6 years ago

I agree that it makes sense to blink the clock at a lower speed. But the TM1637_DEFAULT_BLINK_DELAY constant is also used for the normal blink() method. I would suggest to to use two different constants:

#define TM1637_DEFAULT_BLINK_DELAY 50
#define TM1637_DEFAULT_CLOCK_BLINK_DELAY 500

And add an optional blinkDelay to the printTime() method. If you want and agree with the above you are welcome to make another pull request. I will try to respond a bit quicker this time (sorry for that).

bremme commented 4 years ago

I just implemented this feature, will merge into master later today. Thanks again for you suggestion!