bremor / public_transport_victoria

Custom component for retrieving departure times for Public Transport Victoria.
31 stars 7 forks source link

HA 2024.8.3 - Detected code that calls async_forward_entry_setup for integration #23

Closed kaizersoje closed 1 month ago

kaizersoje commented 2 months ago

I can see a warning in the logs which is pasted below.

2024-08-27 17:40:35.099 WARNING (MainThread) [homeassistant.helpers.frame] Detected code that calls async_forward_entry_setup for integration public_transport_victoria with title: [...] and entry_id: [...], during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.
Stack (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/usr/src/homeassistant/homeassistant/__main__.py", line 223, in <module>
sys.exit(main())
File "/usr/src/homeassistant/homeassistant/__main__.py", line 209, in main
exit_code = runner.run(runtime_conf)
File "/usr/src/homeassistant/homeassistant/runner.py", line 190, in run
return loop.run_until_complete(setup_and_run_hass(runtime_config))
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 674, in run_until_complete
self.run_forever()
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 641, in run_forever
self._run_once()
File "/usr/local/lib/python3.12/asyncio/base_events.py", line 1990, in _run_once
handle._run()
File "/usr/local/lib/python3.12/asyncio/events.py", line 88, in _run
self._context.run(self._callback, *self._args)
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 2161, in async_forward_entry_setup
_report_non_awaited_platform_forwards(entry, "async_forward_entry_setup")
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 1201, in _report_non_awaited_platform_forwards
report(
File "/usr/src/homeassistant/homeassistant/helpers/frame.py", line 151, in report
_LOGGER.warning(msg, stack_info=True)
kaizersoje commented 1 month ago

Hi @bremor, saw this error as well

2024-09-17 06:23:28.713 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'public_transport_victoria' calls async_forward_entry_setup for integration, public_transport_victoria with title: [...] and entry_id: [...], which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead at custom_components/public_transport_victoria/__init__.py, line 45: hass.async_create_task(, please create a bug report at https://github.com/bremor/public_transport_victoria/issues
catatonicChimp commented 1 month ago

Fixed in https://github.com/bremor/public_transport_victoria/commit/e41a10fcb10bf5fc9effe4daf8da2d5c26a4ddb7