brenapp / referee.fyi

https://referee.fyi
3 stars 2 forks source link

Teams in match schedule not on RE Team list #78

Open MiniMitre opened 7 months ago

MiniMitre commented 7 months ago

After using the tool at this event I noticed a bug.

The list of teams given is: RE-VRC-24-5276-Teams-2024-02-16.xls which includes 1408V who did not show up.

The match schedule includes team 3110C (who did show up) in Qualification 1. This was due to TM being re-run with the teams in attendance, but the teamlist on Robot Events not being updated. The result is that the 'New' button does not appear on the match listQualification 1 screenshot with 'new' button missing

And trying to add the violation individually does not work either, the team does not show up when no match is selected on the team list, and when you try to click on the team's number on this screen:

New Report screenshot with team number appearing as selectable

The team is not selected.

MiniMitre commented 7 months ago

Not sure the best way to solve this, it happens as a result of RobotEvents not being set up correctly, which should not happen in an ideal world. However, when trying to get events up and running, sometimes anything goes to get the qualification schedule printed.

So I think it is worth having a check for teams that exist in the match schedule but not in the team list, and adding them to our own list of teams. I think this will show more teams than needed, but it also allows for the situation where we want to record a violation for a team listed on RE, but not on the match schedule (for whatever reason) just in case.

brenapp commented 6 months ago

I would be a bit worried about performance in this case. For example, checking the team list at an event like worlds with thousands of matches might seriously drag performance. Especially with some of the ways we interact with multi-divisional events (i.e. there are situations where would have to fetch all matches from all divisions just to see if there are extra teams).

Definitely worth looking into in this case. I think even an implicit "hey we can't find this team on the team list, but they're on the match list, so load their details directly, and allow users to create reports of them". This would mean that the team would still not be visible on the team list, and probably wouldn't be able to be picked from the team list (without first selecting the match).

What I'm describing above seems like it could be characterized as very buggy behavior, though, so I am not sure.

This is definitely an interesting edge case, and I imagine something that will come up at other future events!

brenapp commented 2 months ago

I think the fix to this is going to come once the Tournament Manager direct integration is supported. That will include a system to update RobotEvents data based on endpoints in the TM API, which should correct for the team list.