search

brendan-duncan / archive

Dart library to encode and decode various archive and compression formats, such as Zip, Tar, GZip, ZLib, and BZip2.
MIT License
395 stars 130 forks source link

feat: `InputStream` to `InputStreamBase` for zlib #300

Closed CaiJingLong closed 8 months ago

CaiJingLong commented 8 months ago

When I was using it, I found that the method signature of zlib's decoder was inconsistent with other decoders. So, I modify to the same signature type.

By the way, if the encoders and decoders have a common mixin/abstract class this problem might not happen.

brendan-duncan commented 8 months ago

Thanks for cleaning it up. I agree, there's lots of ways the code could be cleaned up, I just never have time to do it.