search

brendan-duncan / archive

Dart library to encode and decode various archive and compression formats, such as Zip, Tar, GZip, ZLib, and BZip2.
MIT License
395 stars 130 forks source link

3.4.10 is incorrectly versioned #308

Open bryanoltman opened 6 months ago

bryanoltman commented 6 months ago

Because 3.4.10 includes a new exception that causes an exception to be thrown where it wasn't previously (https://github.com/brendan-duncan/archive/commit/beb640562bc817e873393e4e5c8fd603b153191d), this change caused our app to throw an exception that was not handled. We have fixed this and are checking in our pubspec.lock file to prevent this from happening again.

I'm not sure how this should be addressed (~maybe a 3.4.11 reverting the change that introduced the exception and a 3.5.0 release including that change?~ edit: anything short of a major version bump would not have prevent this from happening), but I wanted to make sure this was known.

brendan-duncan commented 6 months ago

Oh, sorry about that! Version numbering is an art I haven't quite mastered, even after 11 years of this library. It would probably be at version 100 if I updated the major version every time I did something like that.

TheCarpetMerchant commented 5 months ago

@brendan-duncan That is what needs to be done. When you make a breaking change, you prevent this change from being automatically shipped. That's the whole purpose of having a major version number. You need to reverse this change and bump the major version number.