search

brendan-duncan / image

Dart Image Library for opening, manipulating, and saving various different image file formats.
MIT License
1.17k stars 265 forks source link

Created solarize.dart #631

Closed refotografia closed 6 months ago

refotografia commented 6 months ago

Hello there, This is my first pull request ever, I'm not a seasoned coder, specially in Dart. But I had this wish to make a solarization app in Flutter. I just tried this code on a simple app that I made and it gives interesting results.

Summary of changes: -created solarize.dart inside filters folder

Context: -I like the idea of creating solarized images like the portraits of Man Ray that have a washed out grey background instead of black. -a similar filter was not available, but with the information from the invert filter and the normalize filter, I was able to construct something that produced the suitable effects.

Dependencies: -I copied the imports from both other filters I mentioned and later excluded the unused ones.

brendan-duncan commented 6 months ago

That's great. For mode, instead of a string, can you make it an enum for the supported modes?

refotografia commented 6 months ago

Hope I got this the way you imagined now, just learned what enums are.

brendan-duncan commented 6 months ago

Close enough :-). I'll make a couple of changes in a little bit.

brendan-duncan commented 6 months ago

I pushed some cleanup for the code and added it to the docs. https://github.com/brendan-duncan/image/commit/86d41012352e0e089cfad8b5ed121d2c68f4b69a

I like Man Ray's photos, too :-)

refotografia commented 6 months ago

I'll take a look and see what I can learn from that.

refotografia commented 6 months ago

Would be okay to give a try to create a oversaturate function based on issue "Question regarding saturation #313"?

• guilherme maranhão • +351 910 566 522 • https://www.instagram.com/guilherme__maranhao/ • https://refotografia.wordpress.com/

On Sat, Mar 30, 2024 at 9:54 PM Brendan Duncan @.***> wrote:

I pushed some cleanup for the code and added it to the docs. 86d4101 https://github.com/brendan-duncan/image/commit/86d41012352e0e089cfad8b5ed121d2c68f4b69a

I like Man Ray's photos, too :-)

— Reply to this email directly, view it on GitHub https://github.com/brendan-duncan/image/pull/631#issuecomment-2028477816, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGGZAETMW4IFCZJC53H5YFDY24YBFAVCNFSM6AAAAABFPXUETOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGQ3TOOBRGY . You are receiving this because you authored the thread.Message ID: @.***>

brendan-duncan commented 6 months ago

Absolutely. I wish I had more time to work on these dart libraries, but I can just squeeze in time here and there. The help is most definitely appreciated.