search

brendan-duncan / image

Dart Image Library for opening, manipulating, and saving various different image file formats.
MIT License
1.17k stars 265 forks source link

Added s-curve contrast option #650

Closed refotografia closed 4 months ago

refotografia commented 4 months ago

This is a version of the original contrast filter, but using s-curve approach.

brendan-duncan commented 4 months ago

Thanks for this!

I'm going to look at adding this code to the existing contrast function, as an option. There's a bunch of other scaffolding that would need to go in for a new function, and it would add to the technical debt.

refotografia commented 4 months ago

You're welcome!

If you prefer, i can take a shot using enum in the same way as in the solarize filter.

On Sun, 19 May 2024, 04:26 Brendan Duncan, @.***> wrote:

Thanks for this!

I'm going to look at adding this code to the existing contrast function, as an option. There's a bunch of other scaffolding that would need to go in for a new function, and it would add to the technical debt.

— Reply to this email directly, view it on GitHub https://github.com/brendan-duncan/image/pull/650#issuecomment-2119083820, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGGZAETP3QAT7SBJ3QQ4XWDZDALUZAVCNFSM6AAAAABHYLNRC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGA4DGOBSGA . You are receiving this because you authored the thread.Message ID: @.***>

brendan-duncan commented 4 months ago

That would be great. I was thinking something like enum ContrastMode { default, scurve } ... Image contrast(Image src, {required num contrast, Image? mask, Channel maskChannel = Channel.luminance, ContrastMode mode = ContrastMode.default})