search

brendan-w / python-OBD

OBD-II serial module for reading engine data
GNU General Public License v2.0
1.02k stars 360 forks source link

last header fix #174

Closed FakeFact closed 4 years ago

FakeFact commented 4 years ago

If first command's header is ECU_HEADER.ENGINE, it will not set the header.

Ircama commented 4 years ago

The ELM327 adapter should use ECU_HEADER.ENGINE by default, so there should not be any need to force setting the header to 7E0.

Besides, this PR has the drawback to always set the header at the first command after starting python-OBD. I am not sure that this behavior is supported by any ELM327 adapter.

FakeFact commented 4 years ago

My ELM327 always receive data from both 2 ecu (7E8 and 7E9) before i set the header to 7E0. Setting header makes the fast option become even faster because ELM327 dont need to receive reply from both of 2 ecu before returning result.

Still work anyway.