Fix protocol auto detect on BT Elm 327

brendan-w / python-OBD

OBD-II serial module for reading engine data

GNU General Public License v2.0

1.06k stars 369 forks source link

Fix protocol auto detect on BT Elm 327 #220

Closed gmaniak closed 2 years ago

gmaniak commented 3 years ago

Issues addressed

Can't auto detect protocol on BT connection even if the elm devices detects the protocol successfully.

Add delay after erasing stored protocols so the adapter can read the discover command

Summary of testing

Tested on an Mazda MX5. The protocol can be detected successfully on each run. Tested for about 10 times in a row.

Signed-off-by: Catalin Ghenea catalin.ghenea@gmail.com

gmaniak commented 3 years ago

The issue specified here https://github.com/brendan-w/python-OBD/issues/184 seems to be the same this PR fixes.

nohumanman commented 2 years ago

I can confirm this fixes issues preventing correct command identification between Raspberry Pi's and OBD Bluetooth Modules (from 9 commands identified to 32 for me). Please could this pr be merged?

gmaniak commented 2 years ago

This PR has been up for some time now. Is there anything that I should change for it to be merged?