search

brendan-w / python-OBD

OBD-II serial module for reading engine data
GNU General Public License v2.0
1.02k stars 360 forks source link

Define CI pipeline using Github Actions #240

Closed nyukhalov closed 2 years ago

nyukhalov commented 2 years ago

Added a definition of a CI pipeline that the uses tox-gh-actions plugin to correctly propagate python version to tox. I had to drop python 3.4 support as https://github.com/ymyzk/tox-gh-actions does not support it. I will notice that one test is failing for all python versions.

It seems that the test is incorrect, as it expects the map to be empty, but the Protocol class sets a value here: https://github.com/brendan-w/python-OBD/blob/master/obd/protocols/protocol.py#L150. Fixing the tests is out of the scope of this PR.

alistair23 commented 2 years ago

Thanks for this! I have merged it so now the tests will run. Are you able to look at fixing the broken test?

nyukhalov commented 2 years ago

Are you able to look at fixing the broken test?

Yeah, I was going to take a look at it.

nyukhalov commented 2 years ago

@alistair23 done in https://github.com/brendan-w/python-OBD/pull/242. Seems to be an easy fix.