brendan-w / python-OBD

OBD-II serial module for reading engine data
GNU General Public License v2.0
1.02k stars 360 forks source link

append changelog to fulfill the license obligation #256

Closed SilverSteven closed 1 year ago

SilverSteven commented 1 year ago

Missing notice for modifications on original work (violation of GPL-2.0)

[Modification terms and conditions in license] The original work should be honored while the modifications on it should be attached with prominent notices as the license GPL-2.0 dictates. Your project is a forking project from Pbartek/pyobd-pi which adopts GPL-2.0 as its project license. The modification terms and conditions of GPL-2.0 dictate that:

GPL-2.0:

...You must cause the modified files to carry prominent notices stating that you changed the files and the date of any change...

Therefore, I think the project is obligated to abide by the modification terms and conditions in GPL-2.0.

[Violation of modification terms and conditions] I run through your history, and it turns out that you have conducted modifications to the source files of original work while didn't provide prominent notices. You have 22 commits which conduct modifications to the original work, all of which are not declared in README.md. Specifically, of the 22 commits, all commits are not announced in these files. According to the license terms and conditions above, it is regarded as license violation. Thus, to avoid potential legal risks, I would suggest you carry out prominent notices for the 22 commits.

[Fix] For your convenience, I created a PR with by picking up modification-related commit messages. It adds a few lines in changelog without touching the codebase. Please be comfortable to check it out.

Full details of the report you could refer to the html file attached. Hope it helps!

Cheers!

alistair23 commented 1 year ago

I don't think this is required. I have never seen any other GPL project do this. I suspect the git log is enough to indicate which files have been changed.

If you have an example of a GPL project that does this please let me know.