search

brendan-w / python-OBD

OBD-II serial module for reading engine data
GNU General Public License v2.0
1.02k stars 360 forks source link

Some classes in the collections library are deprecated #258

Open ortunoa opened 1 year ago

ortunoa commented 1 year ago

Obd uses MutableMapping and Mapping, which are in util.py and chainmap.py

"from collections import Mapping" needs to be changed to "from collections.abc import Mapping" on util.py "from collections import MutableMapping" needs to be changed to "from collections.abc import MutableMapping" on chainmap.py

lamemakes commented 1 year ago

How did you install the package? There's a discrepancy between what's in the repo and what's in pypi (pip). For me, the pint issues were revolved via: python3 -m pip install git+https://github.com/brendan-w/python-OBD#egg=obd instead of the suggested python3 -m pip install obd. See #252 for more.

Not sure what the state of the project is now, but some docs updates & a new package release would be sweet.

CaptainKatsuura commented 1 year ago

How did you install the package? There's a discrepancy between what's in the repo and what's in pypi (pip). For me, the pint issues were revolved via: python3 -m pip install git+https://github.com/brendan-w/python-OBD#egg=obd instead of the suggested python3 -m pip install obd. See #252 for more.

Not sure what the state of the project is now, but some docs updates & a new package release would be sweet.

in trying this, importing OBD failed due to the pint requirement. Detailed it in #252