Better ELM error handling

brendan-w / python-OBD

OBD-II serial module for reading engine data

GNU General Public License v2.0

1.06k stars 370 forks source link

Better ELM error handling #52

Open brendan-w opened 8 years ago

brendan-w commented 8 years ago

currently, elm327.py only looks for the UNABLE TO CONNECT string. I'd like it to be a little smarter, and know about the other error strings, such as:

NO DATA <--- this one currently gets handled by filtering for hex-only values (a little ugly)
CAN ERROR
BUS ERROR
BUFFER FULL
etc, see pdf pg. 87 of the spec

ffries commented 7 years ago

I think CAN ERROR, BUS ERROR or BUFFER FULL get logged.

But the actions to take are not easy. When BUFFER FULL, you may increase connection speed or enable filtering. BUS ERROR might be a different speed. So all we could do is stop communications, which is not a good thing.