brendanashworth / generate-password

NodeJS library for generating cryptographically-secure passwords.

MIT License

354 stars 67 forks source link

typescript definition file #18

Closed rhyek closed 6 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          48     48           
=====================================
  Hits           48     48

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23642b0...33fb156. Read the comment docs.

brendanashworth commented 7 years ago

@rhyek thank you for taking the time to put this together. Does this definition belong with DefinitelyTyped instead? This would allow imports like require('@types/generate-password').

rhyek commented 7 years ago

It depends on the project's owner, tbh. If you include the type definitions inside this repo, it means users get the definitions automatically instead of having to do the extra step of something like npm install @ types/generate-password. Up to you entirely.

rhyek commented 7 years ago

Bit of a formatting/escaping issue there. The point is to skip doing npm install @types/generate-password.

crutchcorn commented 6 years ago

This would be very nice to have in a release. Is there any word on progress @rhyek?

brendanashworth commented 6 years ago

@crutchcorn thanks for the ping— I'll make the changes I requested and publish a new release over the weekend.

brendanashworth commented 6 years ago

Merged in https://github.com/brendanashworth/generate-password/commit/ef2ded6195ef72ee364172d1ff2c4d107ffe2821, will be putting out a new release soon.

brendanashworth commented 6 years ago

@crutchcorn this is now available in the latest release, v1.4.0.