brendanashworth / generate-password

NodeJS library for generating cryptographically-secure passwords.
MIT License
354 stars 67 forks source link

Generated a password without numbers in them even if specified #19

Closed suppagoddo closed 7 years ago

suppagoddo commented 7 years ago

Used this as option: let passwordOptions = { length: 15, numbers: true, symbols: true }; and called "generator.generate(passwordOptions);"

It generated this password which does not have a number in it.

Generated Password: "q?xfnIaTdWlM?fD"

brendanashworth commented 7 years ago

@suppagoddo just passing the numbers flag allows numbers to be present in the password, it doesn't require them. To require at least one number to be present, you need to set the strict flag:

strict: Boolean, password must include at least one character from each pool.

Like so:

let passwordOptions = {
  length: 15,
  numbers: true,
  symbols: true,
  strict: true
};

generator.generate(passwordOptions);
suppagoddo commented 7 years ago

Cool. Thanks! Got it 👍