search

brendanashworth / generate-password

NodeJS library for generating cryptographically-secure passwords.
MIT License
354 stars 67 forks source link

[Feature request] Ensure minimum character count per pool #27

Open TanukiSharp opened 5 years ago

TanukiSharp commented 5 years ago

Very cool project, thanks :)

It would be great if it could be possible to request a minimum amount of character of each pool, or per pool. For now the documentation of the strict option mentions password must include at least one character from each pool. but it is not rare to encounter system that requires at least 3 uppercase, 2 symbols, and whatnot.

I have no preference how this could be done.

Being able to specify the minimum amount per pool would give more flexibility than having a single number for all the pools, but it's up to you.

Thank you.

ronkorving commented 5 years ago

@brendanashworth Is this the kind of thing you would accept a pull request for? We don't want to fork a project into a separate NPM package if we don't have to. Looking forward to your feedback.

brendanashworth commented 5 years ago

@ronkorving @TanukiSharp apologies for taking so long to respond! I'd accept a pull request for that, but likely don't have time to pursue it on my own. Let me know if it's something you still want to pursue.

ronkorving commented 5 years ago

@brendanashworth Better late than never :) We'll think about it. It's definitely still something we would like to have.