search

brendanashworth / generate-password

NodeJS library for generating cryptographically-secure passwords.
MIT License
354 stars 67 forks source link

Add lowercase property into Options #34

Closed sunjoong85 closed 4 years ago

sunjoong85 commented 4 years ago

lowercase is missing in generate.d.ts

I added it. :)

Thanks!

codecov-io commented 4 years ago

Codecov Report

Merging #34 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          65     65           
=====================================
  Hits           65     65

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25d2c84...a8d37ac. Read the comment docs.

wojciechbator commented 4 years ago

please, introduce this quickfix ;) Sometimes password doesn't match policy for me and You have already implemented support for lowercase in the code itself

brendanashworth commented 4 years ago

Thank you @sunjoong85 and others for bumping me — I've merged this in https://github.com/brendanashworth/generate-password/commit/0eb0f498be34d98c72dd78d4423f9980ca83878a and it's now released as 1.5.1.