brendanhay / amazonka

A comprehensive Amazon Web Services SDK for Haskell.
https://amazonka.brendanhay.nz
Other
599 stars 227 forks source link

Allow aeson-2.1 #803

Closed ysangkok closed 2 years ago

ysangkok commented 2 years ago

Tested using

cabal test --constraint='aeson^>=2.1' -w ghc-9.2.4
endgame commented 2 years ago

Is there a reason for writing ^>= 2.0.0.0 || ^>= 2.1.0.0 instead of >= 2.0 && <2.2? My reading of the package description page says they should be the same?

ysangkok commented 2 years ago

Yes, the reason was that we'd wanna exclude a hypothetical version 1.6 of aeson. I was following the final suggestion of @tfausak on https://github.com/haskell/aeson/issues/881#issuecomment-944920664 . But it sounds like you'd prefer assuming that won't be released, so I have adjusted it.

endgame commented 2 years ago

That's why it was ^>=1.5.0.0 || ^>=2.0.0.0, but you wrote ^>=1.5.0.0 || ^>=2.0.0.0 || ^>=2.1.0.0, which should be equivalent to ^>=1.5.0.0 || >=2.0 && <2.2, by my understanding of how Cabal works. Am I wrong here?

ysangkok commented 2 years ago

Oooh, now I see. I had misread your comment, sorry. I have now revised once again to use your suggested equation ^>=1.5.0.0 || >=2.0 && <2.2.

endgame commented 2 years ago

Thank you for that.