search

brendanhay / amazonka

A comprehensive Amazon Web Services SDK for Haskell.
https://amazonka.brendanhay.nz
Other
599 stars 227 forks source link

Parse more timezones #868

Closed endgame closed 1 year ago

endgame commented 1 year ago

Change the format string for RFC822 to use %Z for any timezone instead of the literal GMT. The use of GMT in that format string goes as far back as I can trace (at least 8 years), so I'm surprised to see errors beginning now. Regardless, it's valid RFC 822 so let's support it.

Fixes #866

endgame commented 1 year ago

@hasufell please test this PR and let me know if it fixes your issue.

hasufell commented 1 year ago

@hasufell please test this PR and let me know if it fixes your issue.

I'm afraid I can't test this easily, because the libraries that I use don't build with amazonka HEAD and I don't have the time to invest in updating all that.

Given that you have a test case using that exact date string, I guess it's probably fine.