brendanhay / amazonka

A comprehensive Amazon Web Services SDK for Haskell.
https://amazonka.brendanhay.nz
Other
599 stars 227 forks source link

Revert "Gen sorted interfaces" #887

Closed endgame closed 1 year ago

endgame commented 1 year ago

Using Data.Map.Map to sort gen outputs caused the ordering of certain fields inside the containers to change, breaking (at least) amazonka-emr-containers. The generator tries to calculate the set of derivable typeclasses through a Ptr, and takes a guess instead of looking up the actual pointed-to type.

I have spent a week and a half trying to make this work, and have decided to give up. More fundamental changes are needed, and they can be done after 2.0. The bug is still present, but the relative ordering of StructF vs Ptr versions of ShapeF within a HashMap hasn't triggered any broken service bindings... yet.

Reverts brendanhay/amazonka#862 Closes #880 Related to #888