search

brendanhay / amazonka

A comprehensive Amazon Web Services SDK for Haskell.
https://amazonka.brendanhay.nz
Other
599 stars 227 forks source link

Change Item in GetItemResponse to optional #896

Closed kokobd closed 1 year ago

kokobd commented 1 year ago

The description at the top of this page says:

If there is no matching item, GetItem does not return any data and there will be no Item element in the response.

Item was marked as "required" by this commit. @endgame Do you know if there are some reasons behind that change?

Fixes #895

endgame commented 1 year ago

If AWS omits that field when there's no item found, then our marking it "required" is in error. Please run scripts/generate --commit dynamodb and push the commit that it generates.

kokobd commented 1 year ago

Regenerated. Should we mention in #739 that we SHOULD generate?

Please don't regenerate services - we do that separately.

endgame commented 1 year ago

I should probably revise that. For generator changes or treewide updates, we do a separate PR to keep the diff clean.