brendanhay / amazonka

A comprehensive Amazon Web Services SDK for Haskell.
https://amazonka.brendanhay.nz
Other
599 stars 227 forks source link

Adding ap-south-2 (Hyderabad) region #900

Closed BharatKJain closed 1 year ago

BharatKJain commented 1 year ago

Added quick fixes for supporting ap-south-2 region, we might have to add support in other places also.

Questions:

Some notes:

endgame commented 1 year ago

Thanks for this. Would you be able to add an entry to lib/amazonka/CHANGELOG.md next to the one for Melbourne?

brendanhay commented 1 year ago

Should we add ap-south-2 support in other places too? Like comments in Chime and Sagemaker lambda ARNs

Note: those specific comments are auto-generated - so the regions are omitted in AWS' own models/documentation, I'd just leave them out in this case.

BharatKJain commented 1 year ago

Thanks for this. Would you be able to add an entry to lib/amazonka/CHANGELOG.md next to the one for Melbourne?

Added.

BharatKJain commented 1 year ago

Ah sorry, missed the link @endgame 😓 , thanks!

endgame commented 1 year ago

No trouble at all. Figured it would be easier if I added it instead of waiting for another round of commits. Thanks for the PR!

BharatKJain commented 1 year ago

@endgame @brendanhay Is it possible to publish a new version of sdk? (1.6.2?)

AWS just released Hyderabad region few weeks back, we wanted to use it in our org, maybe other folks might get blocked on this in future while testing this region.

endgame commented 1 year ago

We hope to announce another release candidate of Amazonka 2.0 Soon™, because all the features and issues assigned to the milestone are essentially done. That needs to happen before 2.0 final goes to Hackage.

Until then, you should use main. Instructions are available at the release announcement for 2.0 RC 1: https://github.com/brendanhay/amazonka/discussions/716

brendanhay commented 1 year ago

If you’ve been using a fork of 1.6.x with the region update, I’d also recommended to do what @endgame suggested above regarding main as there a number of changes which you’ll have to contend with when 2.x lands “soon ™️”.

BharatKJain commented 10 months ago

Hmm, I made a mistake in this PR, ap-south-2 was already present, somehow I overlooked, anyways I checked the current main and it's not having this issue, so it'a fine, I don't have to create a fix PR.