Support `crypton` - Githubissues

brendanhay / amazonka

A comprehensive Amazon Web Services SDK for Haskell.

https://amazonka.brendanhay.nz

Other

598 stars 227 forks source link

Support `crypton` #912

Closed endgame closed 1 year ago

endgame commented 1 year ago

cryptonite has been forked to crypton for ongoing maintenance. We should support it with a flag, defaulting to crypton and falling back to cryptonite.

mbj commented 1 year ago

Why the flag? Context: I'd be happy to send a PR to do the change but would be interested to know why we'd want the flag?

endgame commented 1 year ago

That was an initial guess, before I saw which way things were going to go in the community. I haven't had time to think much about this; are people writing their packages to support both cryptonite and crypton, or has everyone just moved over to crypton?

mbj commented 1 year ago

So far I've seen just moves to crypton and issues that just ask to move to crypton.

https://github.com/snoyberg/conduit/pull/506
https://github.com/yesodweb/wai/pull/931
https://github.com/haskell-servant/servant/pull/1686 (this one stayed on cryptonite for the moment)
https://github.com/snoyberg/http-client/pull/506

none of these have so far AFAIK used a flag. (there are some more PRs unmerged as of yet, also not doing flags).

endgame commented 1 year ago

If those projects beneath us in the depgraph don't use a flag then there's no point us doing so either. The PR should be pretty straightforward, then. Only subtlety is you might need to change the cabal.ede template and (in a separate PR, targeting your main PR) run scripts/generate --commit to rebuild the service bindings.