search

brendanhay / amazonka

A comprehensive Amazon Web Services SDK for Haskell.
https://amazonka.brendanhay.nz
Other
598 stars 227 forks source link

Migration guide #940

Closed endgame closed 1 year ago

endgame commented 1 year ago

Fixes #939

Question: Is it still worth exporting Amazonka.{dynamic,metadata,userdata} from the top-level module, since the metadata interface is mainly for when you don't have an Env? We also only export the top level of IMDS keys, which seems silly.

brendanhay commented 1 year ago

LGTM. I don't feel particularly strongly about the metadata functions being exported or not. Given they are currently, I'd be inclined to leave them that way to not surprise any RC users that might be using them somewhere.

endgame commented 1 year ago

LGTM. I don't feel particularly strongly about the metadata functions being exported or not. Given they are currently, I'd be inclined to leave them that way to not surprise any RC users that might be using them somewhere.

I think it is a very niche use-case, and now that we support all metadata keys described by AWS, the stuff re-exported from Amazonka doesn't cover anywhere near all of them. Also, those functions take an Env instead of a Manager, which is a bit weird. I made sure to call this change out in the migration guide.

If you're happy with this and CI passes cleanly, feel free to hit merge.

endgame commented 1 year ago

CI has passed.