brendanhay / amazonka

A comprehensive Amazon Web Services SDK for Haskell.
https://amazonka.brendanhay.nz
Other
599 stars 227 forks source link

Error handling in periodic credential update #989

Open ynishinaka opened 3 months ago

ynishinaka commented 3 months ago

The fromWebIdentity passes to fetchAuthInBackground the action that performs the AssumeRoleWithWebIdentity [1]. AssumeRoleWithWebIdentity may throw ServiceError (as exception Amazonka.Types.Error), not just HTTPException. However, fetchAuthInBackground catches and throws only HTTPException to the original thread by throwTo, leaving other exceptions to the default handler [2]. Thus, if a ServiceError is thrown, the temporary credential update will be interrupted without the original thread being aware of it.

So, I believe that fetchAuthInBackground should either re-throw other exceptions raised by the action to the original thread or have some error recovery method.


[1] https://github.com/brendanhay/amazonka/blob/ea8679437dd93d2dea74521285d6260d60cea966/lib/amazonka/src/Amazonka/Auth/STS.hs#L80-L94

[2] Because the RetrievalError constructor accepts an argument of type HTTPException, e must be of the same type: https://github.com/brendanhay/amazonka/blob/ea8679437dd93d2dea74521285d6260d60cea966/lib/amazonka/src/Amazonka/Auth/Background.hs#L63-L65