brendanhay / gogol

A comprehensive Google Services SDK for Haskell.
Other
280 stars 105 forks source link

Avoid deprecated servant import. It was removed in 0.17 #144

Closed AlistairB closed 4 years ago

AlistairB commented 4 years ago

Servant.Utils.Links was deprecated in servant 14.1 - https://github.com/haskell-servant/servant/pull/998

It has now been removed entirely in servant 0.17, which breaks gogol-core from building. Switching to the non-deprecated module path fixes it.

This does mean that gogol-core will not build on older than servant 14.1. However 14.1 was released 6 Jul 2018, so I'm hoping that is ok?

Hmm..

ghc 8.6.4 - lts-13.19 uses servant 0.15 :heavy_check_mark: ghc 8.4.4 - lts-12.26 uses servant 0.14.1 :heavy_check_mark: ghc 8.2.2 - lts-11.22 uses servant 0.13 :no_good_man:

So I guess as is this would require dropping ghc 8.2.2 support..

brendanhay commented 4 years ago

S/LGTM, thanks!