Upgrade gen to lts-16.31

madjar commented 3 years ago

I had a hard time running gen, because the needed ghc was not in my nixpkgs anymore. I had issues with the very next version of ghc (darwin issues, and finding working dependency resolution), so I bumped it up to lts-16.31 (ghc 8.8.3).

Outstanding changes are:

Add a dependency to doclayout, which is an extracted part of pandoc we are using
Bump a lot of things
Replace the system-fileio and system-filepath dependencies, because they are deprecated, and failed in a very weird way on my machine (canonicalizePath failing of ..)

Note: ideally, I would rerun the generation on the same input and check it's unchanged, but I'm sadly unable to get stylish-haskell to run on the bigger files, so I could not compare.

madjar commented 3 years ago

Actually, I double-checked the output, and I'm not convinced it actually works. I'm going to spend a bit more time testing this.

madjar commented 3 years ago

Okay, I found the reasons for the differences:

A bug I introduced during the filepath migration (now fixed)
make on osx has subtle incompatibilities with gnu make, so gen was not called with the exact same arguments (fixed by actually using gnu make)
I remembered git diff --ignore-all-space is a thing!

Now, the diff for the fully generated code only has import reordering, as well as a few other changes:

Minor changes in the documentation strings (some identifiers get ' around them, some ascii tables have their width changes). Not sure why that is, but that doesn't sound like a big problem
Changes in prefixes, as expected from the recent changes
More weirdly, in gogol-shopping-content, the version is changed from "v2.1" to "v2", and some fields are changed
A reference in gogol- youtube changed from SLFNewest to SLFPollNewest, and the later doesn't exist, not sure why. As a result, it doesn't compile.

These last two points probably warrant further investigation. Do you have the capability to rerun generation from the develop branch, so we know what changed before, and what's due to this PR?

AlistairB commented 3 years ago

Any reason not to use lts-17 / ghc 8.10.4 ? lts-16 is no longer being updated.

Yeah, for me I just removed the --nix call to run it locally. Otherwise it complained about missing ghc version in nix. Ideally there would be instructions on how to set up the nix stuff to run it.

madjar commented 3 years ago

No good reason, except going to the earliest version that starts working for me. I can definitely bump it more if the objective is to get to the latest lts.

You know what? I'm going to split the system-fileio replacement, which I actually need to be able to run this on my darwin without a huge amount of workarounds, and the lts bump, which is nice but not actually required (contrary to what I believed at some point)

madjar commented 3 years ago

Okay, I messed up the filepath migration, and it introduces more issues.

I'm going to close this PR, and I'll treat the filepath migration and the upgrade as two different topics.

brendanhay / gogol

Upgrade gen to lts-16.31 #157