brendanhay / gogol

A comprehensive Google Services SDK for Haskell.
Other
280 stars 105 forks source link

Remove lenses and use plain field names #169

Closed madjar closed 2 years ago

madjar commented 3 years ago

Hi @brendanhay

I spent a bit of time exploring what it would take to remove lenses from the library and switch to generic-lens and friends. Here is the prototype, and the notes I took about the changes. I hope it's interesting to you!

tl;dr: The hard part is to add comments on the record fields, so quite a bit of rewiring might be required to get to a nice state where the fields are documented.


Complexities that needed to be addressed:

Work that still needs to be done

Now, the actual hard part to figure out:

brendanhay commented 2 years ago

Closed via #174 (which was based on this work.)

madjar commented 2 years ago

Thanks for this!