Some tests are red, travis not executing unit tests.

brendanheywood / moodle-local_cleanurls

Lets drag Moodle's url structure into this century...

37 stars 24 forks source link

Closed roperto closed 7 years ago

roperto commented 7 years ago

Some tests are RED and were not detected by Travis.

roperto commented 7 years ago

We are back to green in development, will merge into master with the fix for issue #40 .

brendanheywood commented 7 years ago

Can you please:

[x] add a test to cover 8f633f133 and -- (Daniel) The test already existed and was failing, see: https://github.com/brendanheywood/moodle-local_cleanurls/blob/460233aa5b76c40902c7f964993cfbb60c1f190d/tests/local_clean_urls_test.php#L307
[x] add back in travis support for all the old moodle's using this feature: (chat to @kenneth-hendricks if you want an example)

kenneth-hendricks commented 7 years ago

Just a heads up - my patch hasn't hit packagist yet. you can either wait for that or change your .travis.yml before_install and env to match: https://github.com/catalyst/moodle-tool_sssfs/blob/c2d30af7c5300de15d9e823511a5c7c91db09fca/.travis.yml

roperto commented 7 years ago

What about applying the patches provided in cleanurls repo after the install in Travis?

If it works, it would also test the patches in the process -- the current patches are not working.

roperto commented 7 years ago

We are green in development, testing Moodle 29+30 (with core patch) + vanilla 31, 32 and master.