search

brendanjmeade / celeri

Next generation earthquake cycle kinematics
BSD 3-Clause "New" or "Revised" License
25 stars 7 forks source link

Statistics in celeri_report #103

Open jploveless opened 2 years ago

jploveless commented 2 years ago

In using celeri_report.py to compare runs with and without snapped segments, I noticed that the number of segments is the same. This is because the number is read from the copy of the input segment .csv rather than from model_segment.csv. I wonder if it would make sense to read information from the model_ files so that the information reported in celeri_report.py reflects conditions used in the model run, rather than strictly input conditions. Another example of this could be reporting the number of toggled-on stations that were used in the run, rather than the number of stations in total.

brendanjmeade commented 2 years ago

100% agree and I've added these to the TODOs in #100.

A related issue is that it is currently reporting command parameters from the initial command file rather than from the command dict that can be overwritten by command line options. My solution here is going to be to write a second command file to the output folder that contains the content of the command dictionary. celeri_report can then read that and the implemented command line options will all be there!