search

brendanjmeade / celeri

Next generation earthquake cycle kinematics
BSD 3-Clause "New" or "Revised" License
24 stars 6 forks source link

Consider and check the ordering of blocks.block_label #24

Closed brendanjmeade closed 2 years ago

brendanjmeade commented 2 years ago

Do I have to reorder the blocks dataframe so that block label 0 is at the top?

Currently, this appears to have already been done block.block_label appears to be ordered, so have the dataframe rows already been sorted. This is unlikely to happen coincidently because the interior points are not (in general) ordered.

brendanjmeade commented 2 years ago

Yes, I did have to reorder the block data frame to achieve this. See commit https://github.com/brendanjmeade/celeri/commit/eaf6f28dccedad5535b37ad88ccdcbd8d640f1ba. For reasons I don't understand I had to return block from the function as well. I opened a new issue (#27) for that one.