brendanjmeade / celeri

Next generation earthquake cycle kinematics
BSD 3-Clause "New" or "Revised" License
24 stars 6 forks source link

Fixed indexing but partials calculations have empty columns? #76

Closed jploveless closed 2 years ago

jploveless commented 2 years ago

The inversion fails with a singular matrix error. I assume this is due to some columns being all zeros, and this seems to be the case from some of the troubleshooting I placed into the bottom of the solver code block, but I can't figure it out. Looks like there are zero columns corresponding to the first few columns of TDE partials (63, 64, 65…) but then when I try to check that matrix of partials itself, it's not reporting any zero columns, so clearly my Python inexperience is causing some issues here. But, if the TDE partials indeed contain some all-zero columns, I'm not sure how to fix that.

Any ideas?

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

brendanjmeade commented 2 years ago

I'm merging this.

@jploveless From your description this sounds like a matrix assembly issue likely focused on estimation.operator?

brendanjmeade commented 2 years ago

It looks like most of the estimation.operators matrix is empty right now, so that's something to go on!

spy(estimation operator)
jploveless commented 2 years ago

Okay, I think I have some indexing suspicions about inserting the TDE partials into estimation.operators, and I will try to check that out soon.

On Wed, Feb 9, 2022 at 10:54 PM Brendan Meade @.***> wrote:

It looks like most of the estimation.operators matrix is empty right now, so that's something to go on! [image: spy(estimation operator)] https://user-images.githubusercontent.com/4225359/153334024-9b38b9fc-2f66-4da0-9d02-4214bd60bf58.png

— Reply to this email directly, view it on GitHub https://github.com/brendanjmeade/celeri/pull/76#issuecomment-1034466702, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZQE4UATYYHALOHUERXHF3U2MZGJANCNFSM5N65LBEA . You are receiving this because you were mentioned.Message ID: @.***>