search

brendankenny / vitals-flow

Apache License 2.0
16 stars 1 forks source link

Better Responsiveness Snippet. #1

Open mmocny opened 2 years ago

mmocny commented 2 years ago

I haven't had a chance to play with this flow yet, just going through the docs and a bit of the implementation to get a feel for it.

I noticed that the responsiveness snippet is still using an older set of experiments. I have created a more up-to-date snippet recently which perhaps could be used to update.

If you don't get around to it I'll see about creating a PR when I actually have a chance to try this flow locally.

brendankenny commented 2 years ago

I probably won't get to this for a little while yet, but happy to take a PR!

When I wrote the responsiveness audit I couldn't find a precise description of the high-percentile candidate yet (and I never got around to converting the online/streaming version that was in Chrome). The definition now looks straightforward, so shouldn't be much work to drop in place of the aggregations already in there.

I noticed that the responsiveness snippet is still using an older set of experiments. I have created a more up-to-date snippet recently which perhaps could be used to update.

Is that necessary since it's running over the trace rather than in-page?