search

brendanneojw / pe

0 stars 0 forks source link

Creation of course allows blank spaces to be valid course codes #3

Open brendanneojw opened 1 year ago

brendanneojw commented 1 year ago

The course create feature still succeed even with no course code given i.e. blank spaces

Steps to reproduce

course create course/

Expected

Is not a valid course code, hence it should show an error rather than adding it into the list of address books

Actual

Address book is still created.

image.png

nus-se-script commented 1 year ago

Team's Response

This is clearly stated in the UG to be acceptable. While the empty string may not be a valid course code in NUS, it is expected behaviour documented clearly in the UG, and not a functionality bug.

Screenshot 2023-11-18 at 3.06.23 PM.png

Additionally, to address the feature flaw that invalid course codes are allowed, we have also added, under Planned Enhancements #3, that there would be stricter validation checks for valid course codes in future versions.

Since this is not a valid functionality bug, and this feature flaw matches a Planned Enhancement, we have deemed this bug report to be invalid, and rejected it.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]