brendanneojw / pe

0 stars 0 forks source link

Tutorial Group ID does not support case-insensitivity in list attendance feature #6

Open brendanneojw opened 1 year ago

brendanneojw commented 1 year ago

For the list attendance feature, when passing in the TUTORIAL_GROUP_ID parameter, it does not detect the tutorial group if the case of the letter is wrong. It is not mentioned anywhere that it is not case-sensitive.

Steps to reproduce

First there are 2 students in G01 tutorial group

image.png

Using the command list attendance w/0 tg/g01

Expected

Should still display the same output as if the command given was list attendance w/0 tg/G01

Actual

Shows error message that the tutorial group can't be found

image.png

nus-se-bot commented 1 year ago

Team's Response

This is mentioned in #1781. Fixing #1781 would fix this as well, as it involves adding duplicate detection and making tutorial groups case-insensitive. This bug report is also on making tutorial groups case-insensitive (recognising g2 and G2 as the same tutorial group).

As such, we marked it as a duplicate.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Simple duplicate Detection in names and tags.

Running the following command

image.png

adds this person

image.png

Perhaps can consider checking for extra spaces and make tutorial groups case insensitive to catch duplicate tutorial groups.


[original: nus-cs2103-AY2324S1/pe-interim#2554] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted - but we have changed it to a feature flaw as per the course website (duplicate detection).

We will add case-insensitivity for all tutorial group inputs and check for extra spaces in names in future version, to rectify this feature flaw.

Screenshot 2023-11-18 at 7.45.43 PM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]