valid phone number is not allowed

[brendanng7]

+659999999 should be allowed as a phone number. The app doesn't allow area codes or dialing codes which should be allowed for this application as the user guide does not state it is only for Singaporeans. It could be used internationally. I could have international friends and their phone number must have dialing codes.

[soc-se-bot]

Team's Response

Thanks for submitting this report.

Comments from dev team: Let us explain why it is this way:

phone numbers should generally only contain numbers, it is in the name phone numbers
users can still input the country code without the +
users can use the tag feature to label contacts as "HP" or "Office" if needed

Bug Type that we chose: feature flaw The error screen clearly shows that only numbers are allowed, this is intended behavior, not a bug

Severity that we chose: low This would only affect a small portion of users, and there are plenty of workarounds given above.

Decision that we made: not in scope

According to the course website, this can be classified not in scope. The implementation of tag and link features are more important than this minor issue, and do note that the tag features already solves one part of your bug report. On top of that, the user input is handled gracefully as you can see in the clear error message.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add characters to phone number in adding person entry

Steps to recreate: 1) add p n/Maaran p/+65 91234567 e/maaran@example.com a/Newgate Prison

It is good that the phone contact entry only has a minimum boundary to check if it's a valid number but in real world cases some users might wish to add characters like "+" for country code or "HP" to indicate handphone to the contact entry. Rather than not accepting any entries with non numeric characters, a warning could be thrown instead to warn users but still allow non numeric characters to contact entry.

---

_{[original: nus-cs2103-AY2425S1/pe-interim#2484] [original labels: severity.Low type.FunctionalityBug]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for submitting this report.

Comments from dev team: Let us explain why it is this way:

• phone numbers should generally only contain numbers, it is in the name phone numbers
• users can still input the country code without the +
• users can use the tag feature to label contacts as "HP" or "Office" if needed

Bug Type that we chose: feature flaw The error screen clearly shows that only numbers are allowed, this is intended behavior, not a bug

Severity that we chose: low This would only affect a small portion of users, and there are plenty of workarounds given above.

Decision that we made: not in scope

According to the course website, this can be classified not in scope. The implementation of tag and link features are more important than this minor issue, and do note that the tag features already solves one part of your bug report. On top of that, the user input is handled gracefully as you can see in the clear error message.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:**  It doesn't take much effort to relax the regex constraint on phone numbers to allow users to input the '+' sign for country code. Since the dev team didn't state that the product is for local use, it is safer to assume that it is for international use and hence country codes will be very important. It is very possible for me to want to make plans with international friends. Hence, I disagree with the team's decision to classify this bug as not in scope.

---

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]

---

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only. This issue appears quite often since it is quite common for users to have friends and/or family who are living overseas and users might plan to visit their overseas friend and families over the holidays. #### phone numbers should generally only contain numbers, it is in the name phone numbers:  I believe this is not true as a quick google search would inform that phone numbers should include the area code as well. #### users can still input the country code without the +: This will lead to inaccuracies as the user would not know which part of the phone number is the country code. #### users can use the tag feature to label contacts as "HP" or "Office" if needed: While the user could input the country as the tag, this will still be inconvenient for the user as they will have to go search for the country code online. Hence, I think a medium severity is more fitting as users can still use the product although with some inconvenience.

---