search

brendanzab / codespan

Beautiful diagnostic reporting for text-based programming languages.
Apache License 2.0
1.1k stars 59 forks source link

Cut codespan release with fix? #316

Closed Jake-Shadle closed 3 years ago

Jake-Shadle commented 3 years ago

I was upgrading to 0.11.0 and noticed that ca59f8afdaa05113816cdcb2c41b4a471cc1d50c fixed the issue where codespan_reporting::files::Files isn't implemented for codespan::Files, but it isn't released yet.

Michael-F-Bryan commented 3 years ago

I got bitten by this too.

It looks like the impl is guarded by a #[cfg(feature = "reporting")], but the Cargo.toml doesn't actually say that feature exists.

error: failed to select a version for `codespan`.
    ... required by package `mdbook-linkcheck v0.7.3-alpha.0 (/home/michael/Documents/mdbook-linkcheck)`
versions that meet the requirements `=0.11.0` are: 0.11.0

the package `mdbook-linkcheck` depends on `codespan`, with features: `reporting` but `codespan` does not have these features.

failed to select a version for `codespan` which could resolve this conflict
Johann150 commented 3 years ago

@Michael-F-Bryan the issue itself was already solved in #309, we only need one of the crate owners on crates.io (@Marwes or @brendanzab) to make a new release.

brendanzab commented 3 years ago

I'll get onto this today!

brendanzab commented 3 years ago

Should be released now!

Jake-Shadle commented 3 years ago

Thanks!