brendanzab / gl-rs

An OpenGL function pointer loader for Rust
Apache License 2.0
678 stars 117 forks source link

The big 2018 cleanup #507

Closed Lokathor closed 4 years ago

Lokathor commented 4 years ago

Highlights:


So, because of that last point, basically every test fails to build, to the point where we can't even test that the output is still good or not.

So we need to decide what to do there. We could preserve the include! ability of the output, but then people would manually have to put all sorts of allow(foo) tags on whatever module does the include.

Lokathor commented 4 years ago

And just to be extra clear: this will at least slightly break nearly every user of the crate when they upgrade from 0.14 to 0.15, because the loader function is passing *const c_char instead of &str now, but it's for their own good.

brendanzab commented 4 years ago

This is looking good! Still need to look closer though, I've only done a cursory pass over it right now.

I'm also really interested in what people downstream have to say.

brendanzab commented 4 years ago

Re. ffe151eec35ce2e592324d77c993754a323c38ce, I do see many people using the static stuff for the platform-specific extensions. For example ocl-interop and rust-glx. Should we be getting folks to use the loaders for these, or is this accepted as best-practice in this case?

Lokathor commented 4 years ago

As discussed on Discord, closing this until more time can be found to work on this repo.