search

brenden / node-webshot

Easy website screenshots in Node.js
2.12k stars 286 forks source link

Update to phantomjs 2.0 #100

Open LorenzGardner opened 9 years ago

LorenzGardner commented 9 years ago

Please consider pulling in the latest stable phantomjs.

Workaround: One could use the path option to specify a diff phantomJs than the one pulled down by npm.

brenden commented 9 years ago

The latest version of the phantomjs package (1.9.16) does currently get pulled in, but it looks like that package hasn't yet been updated to install phantom 2.

Related issue: https://github.com/Medium/phantomjs/issues/288

davidhlee commented 9 years ago

+1

https://www.npmjs.com/package/phantomjs2

lukepolo commented 9 years ago

:+1:

lukepolo commented 9 years ago

On ubuntu Ubuntu 14.10 i was able to use : https://github.com/Pyppe/phantomjs2.0-ubuntu14.04x64 No problems so far!

brenden commented 9 years ago

It looks like phantomjs v2 still has some issues. I'd rather just defer to the judgement of Medium/phantomjs's maintainers and wait until they move to a v2 release.

In the meantime the workaround mentioned by LorenzGardner should work fine for anyone who needs to use v2 and I'll update the readme to mention it.

bradvogel commented 9 years ago

For anyone following along: you can use phantomjs2 by npm installing phantomjs2 and then passing this to webshot:

phantomPath: require('phantomjs2').path
geekbleek commented 9 years ago

Are there any plans to move to or give the option of using slimerjs? It seems to be much more stable in terms of output reliability of screenshots than phantomjs (I'm getting renderings of all types of various "sizes" as presented by the remote end under phantomjs)

ghost commented 8 years ago

It looks like this is now fixed with commit https://github.com/brenden/node-webshot/commit/ecc3917f9368e804c46b864be6079e383428e477